Make default layer size 16-bit #15286

drashna · 2021-11-23T20:36:25Z

Description

Set the layer state to be 16-bit by default.

I would rather set this to 8-bit, but until the configurator can handle that without issue, ... it supports 16 layers, so this would work in the meanwhile.

And this allows for smaller compiled sizes.

Types of Changes

Core
Enhancement/optimization
Documentation

Checklist

My code follows the code style of this project: C, Python
I have read the PR Checklist document and have made the appropriate changes.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
I have tested the changes and verified that they work and don't break anything (as well as I can manage).

KarlK90

LGTM and is a sane default.

precondition · 2021-11-27T18:01:00Z

I can already hear the unrest that would come from the havoc caused by all the biton32 in the wild no longer working. Other than that, I'm in favor of this.

fauxpark · 2021-11-27T18:03:02Z

That's why you're supposed to use get_highest_layer() instead ;)

precondition · 2021-11-27T18:04:53Z

Yes, indeed but I still see too many people on the QMK discord server posting code bits using biton32 instead of get_highest_layer :(

precondition · 2021-11-27T18:19:09Z

Speaking of biton32, shouldn't the ~265 user files calling the biton32 function in place of get_highest_layer get changed in this PR too? For example:

keyboards/bpiphany/kitten_paw/keymaps/ickerwx/keymap.c:135:    layer = biton32(layer_state);

fauxpark · 2021-11-27T18:19:50Z

We try to avoid changing user code en masse like that...
Core and default-ish keymaps are fair game though.

drashna · 2021-11-27T18:23:07Z

Yes, indeed but I still see too many people on the QMK discord server posting code bits using biton32 instead of get_highest_layer :(

That's because it in a lot of the default keymaps. And people copy and paste code.

But I've been flagging that in any new PRs, so more copy-paste code hasn't been incorrectly added.

Edit: I've updated the default keymaps, docs, and associated kb files to use get_highest_layer when appropriate, now.

drashna · 2021-11-28T02:52:31Z

Speaking of biton32, shouldn't the ~265 user files calling the biton32 function in place of get_highest_layer get changed in this PR too? For example:
keyboards/bpiphany/kitten_paw/keymaps/ickerwx/keymap.c:135:    layer = biton32(layer_state);

Also, some of the rational behind not changing all of the user files doing this (besides, "that's a lot of work"), is that using biton32 will work and "fail gracefully". So there is no harm in leaving it. But future examples and the default keymps should use the correct function.

zvecr · 2021-12-02T22:55:16Z

Also worth noting that the configurator currently supports more than 8 layers. And some keyboards also set DYNAMIC_KEYMAP_LAYER_COUNT greater than 8.

drashna · 2021-12-04T06:21:42Z

Also worth noting that the configurator currently supports more than 8 layers. And some keyboards also set DYNAMIC_KEYMAP_LAYER_COUNT greater than 8.

The dynamic keymap layer count is already taken into account, but github doesn't show a lot of context. Literally, right above:

https://github.com/qmk/qmk_firmware/blob/c76cfc2d36ead86a5ec9e4d5061a28987b0bca18/quantum/action_layer.h#L24-L41

However, the configurator is a good point, and this PR should wait to be merged until there is something in place to handle that.

noroadsleft · 2022-01-13T04:05:52Z

Merge conflicts.

keyboards/helix/rev3_5rows/keymaps/five_rows/keymap.c

keyboards/helix/rev2/keymaps/five_rows/keymap.c

keyboards/helix/rev2/keymaps/edvorakjp/keymap.c

Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>

…ayer_size

tzarc · 2022-05-15T11:15:45Z

Seems to break the helix boards.

tzarc · 2022-05-15T11:16:27Z

Deferred to Q3 so helix can be fixed and verified.

drashna · 2022-06-18T03:38:48Z

Deferred to Q3 so helix can be fixed and verified.

How was this breaking the helix boards?

I do see one keymap that won't compile, but that's because it's doing some really weird stuff. All the rest compile. However, I don't have a board to test on.

tzarc · 2022-06-18T06:53:22Z

I don't remember, and at this stage I'm inclined to say "develop can break, we can fix over time if issues occur".

Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>

qmk/qmk_firmware#15286 (comment)

github-actions bot added the core label Nov 23, 2021

KarlK90 approved these changes Nov 24, 2021

View reviewed changes

github-actions bot added keyboard keymap labels Nov 24, 2021

precondition approved these changes Nov 27, 2021

View reviewed changes

drashna force-pushed the core/set_default_layer_size branch from a2b90a6 to 5c98461 Compare November 27, 2021 18:30

github-actions bot added documentation python translation via Adds via keymap and/or updates keyboard for via support labels Nov 27, 2021

drashna force-pushed the core/set_default_layer_size branch from 5c98461 to ade1290 Compare November 27, 2021 18:39

github-actions bot removed the python label Nov 27, 2021

drashna marked this pull request as ready for review November 28, 2021 02:49

drashna requested a review from a team November 28, 2021 02:50

drashna force-pushed the core/set_default_layer_size branch from ade1290 to 4cf2296 Compare December 4, 2021 06:14

drashna force-pushed the core/set_default_layer_size branch from 4cf2296 to 32f3006 Compare January 8, 2022 03:09

drashna changed the title ~~Make default layer size 8-bit~~ Make default layer size 16-bit Jan 8, 2022

drashna force-pushed the core/set_default_layer_size branch from 32f3006 to 5db91e7 Compare January 13, 2022 04:49

drashna force-pushed the core/set_default_layer_size branch from 5db91e7 to fb64c4b Compare January 22, 2022 17:53

fauxpark requested changes Jan 22, 2022

View reviewed changes

keyboards/helix/rev3_5rows/keymaps/five_rows/keymap.c Outdated Show resolved Hide resolved

keyboards/helix/rev2/keymaps/five_rows/keymap.c Outdated Show resolved Hide resolved

keyboards/helix/rev2/keymaps/edvorakjp/keymap.c Outdated Show resolved Hide resolved

drashna force-pushed the core/set_default_layer_size branch from ac28772 to dab2d54 Compare February 26, 2022 02:55

noroadsleft approved these changes Mar 4, 2022

View reviewed changes

drashna requested a review from a team March 4, 2022 18:54

drashna and others added 11 commits March 15, 2022 17:54

Make default layer size 8-bit

be78a57

fix cannonkeys/ortho75 layer types

e2a36bb

Update all old layer state code

a86a5f5

Fix compile issues due to layer mask type change

6385f13

Change behavior in default keymaps, keyboards and docs

6146e11

Change default to 16 layers

d52a356

Replace everything

5734012

Fix ergodox script

280ae60

fix linter

a7c0045

Fix additional keymaps

48da300

fix

737732e

Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>

drashna force-pushed the core/set_default_layer_size branch from dab2d54 to 737732e Compare March 16, 2022 00:55

tzarc approved these changes Apr 5, 2022

View reviewed changes

precondition mentioned this pull request Apr 13, 2022

Remove IGNORE_MOD_TAP_INTERRUPT_PER_KEY in favour of HOLD_ON_OTHER_KEY_PRESS_PER_KEY #15741

Merged

14 tasks

Merge remote-tracking branch 'origin/develop' into core/set_default_l…

d61e857

…ayer_size

tzarc added breaking_change_2022q3 and removed breaking_change_2022q2 labels May 15, 2022

Merge remote-tracking branch 'origin/develop'

eeb5a62

tzarc merged commit 0da6562 into qmk:develop Jun 18, 2022

drashna deleted the core/set_default_layer_size branch June 21, 2022 00:23

0xcharly pushed a commit to Bastardkb/bastardkb-qmk that referenced this pull request Jul 4, 2022

Make default layer size 16-bit (qmk#15286)

a4c8636

Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>

rschenk added a commit to rschenk/qmk_keymaps that referenced this pull request Sep 21, 2022

Update keymap for v0.18

5663525

qmk/qmk_firmware#15286 (comment)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make default layer size 16-bit #15286

Make default layer size 16-bit #15286

drashna commented Nov 23, 2021 •

edited

Loading

KarlK90 left a comment

precondition commented Nov 27, 2021

fauxpark commented Nov 27, 2021

precondition commented Nov 27, 2021

precondition commented Nov 27, 2021

fauxpark commented Nov 27, 2021 •

edited

Loading

drashna commented Nov 27, 2021 •

edited

Loading

drashna commented Nov 28, 2021

zvecr commented Dec 2, 2021 •

edited

Loading

drashna commented Dec 4, 2021

noroadsleft commented Jan 13, 2022

tzarc commented May 15, 2022

tzarc commented May 15, 2022

drashna commented Jun 18, 2022

tzarc commented Jun 18, 2022

Make default layer size 16-bit #15286

Make default layer size 16-bit #15286

Conversation

drashna commented Nov 23, 2021 • edited Loading

Description

Types of Changes

Checklist

KarlK90 left a comment

Choose a reason for hiding this comment

precondition commented Nov 27, 2021

fauxpark commented Nov 27, 2021

precondition commented Nov 27, 2021

precondition commented Nov 27, 2021

fauxpark commented Nov 27, 2021 • edited Loading

drashna commented Nov 27, 2021 • edited Loading

drashna commented Nov 28, 2021

zvecr commented Dec 2, 2021 • edited Loading

drashna commented Dec 4, 2021

noroadsleft commented Jan 13, 2022

tzarc commented May 15, 2022

tzarc commented May 15, 2022

drashna commented Jun 18, 2022

tzarc commented Jun 18, 2022

drashna commented Nov 23, 2021 •

edited

Loading

fauxpark commented Nov 27, 2021 •

edited

Loading

drashna commented Nov 27, 2021 •

edited

Loading

zvecr commented Dec 2, 2021 •

edited

Loading